search

Nerian / bootstrap-datepicker-rails

A Datepicker for Twitter Bootstrap, integrated with Rails assets pipeline
MIT License
648 stars 182 forks source link

Replace deprecated jQuery functions #145

Closed simon-isler closed 3 years ago

simon-isler commented 3 years ago

jQuery.isArray and jQuery.isFunction are deprecated, so I replaced them using Array.isArray and typeof

Nerian commented 3 years ago

Hi @simon-isler,

Thanks for your contribution. But this repository just packages the JS code. The actual development for the datepicker lies here: https://github.com/uxsolutions/bootstrap-datepicker. So please send your PR there. Once they merge it, I can update this gem.

Thanks!

simon-isler commented 3 years ago

Hi @simon-isler,

Thanks for your contribution. But this repository just packages the JS code. The actual development for the datepicker lies here: uxsolutions/bootstrap-datepicker. So please send your PR there. Once they merge it, I can update this gem.

Thanks!

Hi @Nerian,

Thanks for your answer - I did not see that 👍 A PR for the same issue was already merged, but unfortunately not released yet (https://github.com/uxsolutions/bootstrap-datepicker/pull/2579).