search

Neriderc / GVExport

Repository for GVExport module for Webtrees
GNU General Public License v2.0
15 stars 6 forks source link

Rounded rectangle tiles with gender coloured border #381

Closed Neriderc closed 1 year ago

Neriderc commented 1 year ago

I've been playing with the design and have had the idea for two more settings. One is for rounded rectangle borders around the individuals' tiles, and one is to replace the coloured stripe with a sex-coloured border.

Combined it would look like this: image

Because GVE is very customisable now, I propose adding these as two separate options.

Making the border rounded rectangles causes an overlap as follows: image

I have not been able to work out a way to have this correctly displayed, so instead I propose adding the option to show coloured borders instead. Perhaps if rounded rectangle tiles is chosen, the coloured stripe is not available and the only options for sex colouring are "none" or "border", with "stripe" only being available if rounded rectangle tiles are disabled.

Neriderc commented 1 year ago

Can we remove the "Simple" diagram type if we add an option to set the background based on sex (like how it works for the "Simple" diagram type)? It seems to me this is the only thing stopping you from creating the same look with the "Decorated" style.

Thoughts?

hartenthaler commented 1 year ago

You are right! Having only two basic styles: "xxx" and "combined" would be much more straightforward. How to name the "xxx"? I do not like "decorated"; "separated" or "simple"?

And it would be nice to have the option to set the background based on sex (using the same colours we have already for sex?).

This would be a new issue.

Neriderc commented 1 year ago

You're right, this should be a new issue, but it also solves some problems with this one. I will make a new issue for this, and for this one will not do dynamic hiding of options that don't work with Simple mode, and we will make sure to do both before the next release.

I would prefer not to rename "Decorated" to "Simple", because it has a previous use it could be confusing, and anyway it gives the impression that one option is simpler and one more advanced, when really the options are equal but different. I like "Separated" and "Combined"