search

Neriderc / GVExport

Repository for GVExport module for Webtrees
GNU General Public License v2.0
15 stars 6 forks source link

Error when using empty boxes #459

Closed hartenthaler closed 7 months ago

hartenthaler commented 8 months ago

This happened when I tried to use empty boxes (no name, no birth/death data/no images).

Screenshot (457)

Neriderc commented 8 months ago

It's working for me:

Click for screenshot of diagram with no details

Is there any more info you can provide? The error is for I567, which is the last in the list of individuals which makes me think there is something special about that individual. If you download the DOT file, is there anything in that line that looks different from the others?

Neriderc commented 8 months ago

Did you manage to work out what is wrong? I'd like to release a new version, but don't want to do that if there's a bug in it. But I haven't been able to reproduce it.

schuco commented 8 months ago

There is another issue you might check before the new release: When the option is set to style individuals based on shared note and then I load a saved setting, which had been saved in a former release of GVExport where the style-option did not yet exist, the saved setting is displayed in shared note style. This works correctly, i.e. looks as it was saved, when the setting had been saved in the new release of GVExport.

Neriderc commented 8 months ago

There is another issue you might check before the new release: When the option is set to style individuals based on shared note and then I load a saved setting, which had been saved in a former release of GVExport where the style-option did not yet exist, the saved setting is displayed in shared note style. This works correctly, i.e. looks as it was saved, when the setting had been saved in the new release of GVExport.

Ah yes, when loading settings we don't set them to defaults first. If there isn't a setting in the saved settings, it won't be changed. I'll have to have a think about how to solve this.

Neriderc commented 8 months ago

@schuco I decided for the sake of loading speed that I'd resolve this issue directly, by checking for that value and add it in as blank if it didn't exist in the saved setting, which should resolve the issue (it does for me).

@hartenthaler it would be great if you could add some more info about your issue as I haven't been able to reproduce it.

Neriderc commented 7 months ago

@hartenthaler any further issues with this?

hartenthaler commented 7 months ago

Sorry, I was not able to reproduce that issue. I think you should close it. Whenever it appears again I will remember.