Neriderc / GVExport

Repository for GVExport module for Webtrees
GNU General Public License v2.0
15 stars 6 forks source link

Add name abbreviation "First given name and surname" #470

Closed Neriderc closed 5 months ago

Neriderc commented 5 months ago

The name abbreviation "First given name and surname" would be great for complete but compact diagrams.

Originally posted by @marwelin in https://github.com/Neriderc/GVExport/issues/232#issuecomment-2006655946

Neriderc commented 5 months ago

@marwelin sorry I'm just realising now that I don't understand how this is different from "Given and Surnames", which is a current abbreviation option. Webtrees doesn't distinguish between first and middle names, so we grab the first word from the "Given names" field.

Neriderc commented 5 months ago

Sorry again - I was wrong about the above. "Give and Surnames" includes all given names. We want an option to include just the first given name and the surname.

marwelin commented 5 months ago

I think it is not the first given name and the surname. Ideally it is the normally used given name and the surname.

For example: James Paul McCartney - this is the genealogy format, with the underlined usually used given name. James Paul* McCartney - this is the webtrees format which renders to the genealogy format

The compact name in GVExport should ideally show the normally used given name and the surname. In this case: Paul McCartney

If there is no given name marked with a star, the first given name can be used. So, if Paul would not be marked with a star, the name would be James McCartney

Neriderc commented 5 months ago

Great, thanks! I'll do it as you describe.

I think perhaps "First given name and surname" isn't an appropriate name. Perhaps something more like "Preferred name and surname"?

Is the term you used, "usually used given name", a normal way of describing this in genealogy? Perhaps that would be a more appropriate label?

Another thing, if there are two starred first names, do we show both?

marwelin commented 5 months ago

I don't know a normal way of describing this in genealogy, but what do you think of

The "primary given name" can then be described as either the starred given name or the first given name. I think if there are multiple starred given names, they should be shown all.

Some background information: Wikipedia differentiates the given name in given name (or first name) and middle name, where webtrees puts all names into the given name (except of the surname). Beside that there is the nickname.

For example: Martin Seamus "Marty" McFly

In Germany the starred name is the "Rufname", which is something like "call name".

hartenthaler commented 5 months ago

I would prefer: "Preferred name" or a bit more descriptive "Preferred given name and surname".

There should be only one preferred given name marked by an asterisk. But if there are two or more I would expect to see them all, ie to show "Hans Jürgen Meier" for "Robert Hans Jürgen /Meier/" and to not underline any part of the name in this case.

The asterisk is a speciality of webtrees and some other programs, it is not standard GEDCOM. The custom GEDCOM tag NAME:_RUFNAME is supported by many German genealogy programs. It is defined in the "GEDCOM-L addendum" https://genealogy.net/GEDCOM/GEDCOM551%20GEDCOM-L%20Addendum-R2.pdf

Neriderc commented 5 months ago

There should be only one preferred given name marked by an asterisk.

In thinking about this a bit more, names can be two words. For example, here in New Zealand there are some common Māori names that start with a particle "Te". For example:

So to mark this as a preferred name, you'd need to star both parts in webtrees, and so we would need to make sure this carries through properly.

I would prefer: "Preferred name" or a bit more descriptive "Preferred given name and surname".

"Preferred given name and surname" seems better, as users might expect "Preferred name" to only show the preferred given name. It's a little long, but a similar length to "Given name initials and surname" that we already have.

Neriderc commented 5 months ago

I've completed this now and merged into main. Feel free to update from main and test it out.

marwelin commented 5 months ago

For me, that looks fine. I like this compact view very much. Thank you for implementing it.

Neriderc commented 5 months ago

Thanks for the suggestions! It's nice to have some easy changes to do :smile: