Neriderc / GVExport

Repository for GVExport module for Webtrees
GNU General Public License v2.0
15 stars 6 forks source link

Add option to sort saved settings #482

Closed schuco closed 4 months ago

schuco commented 4 months ago

After adding the 45th saved setting this was no more displayed in the saved setting list. So I can't delete, download, rename etc. this setting. This setting can be seen in the list of saved diagrams. Also it would be fine if both lists (saved diagrams and saved settings) were displayed in sorted order (by name).

Neriderc commented 4 months ago

I can't reproduce this. Though I did notice something odd. I added these in number order, but numbers 35-44 are placed in the wrong place.

You're sure your new ones aren't just sorted into the wrong place?

screenshot of list of saved settings numbered from 1 to 50, showing unusual order as mentioned above

schuco commented 4 months ago

Excuse me! I was wrong. grafik

The setting has been hidden somewhere in between older settings.

Still the question, if not sorting of the list could be implemented

Neriderc commented 4 months ago

Well that's good! I'm happy it's working, just confusing.

Let's leave this open as the record of this and I'll implement some sort of sorting. I think it's probably related to how we store IDs in base 36, which we had a good reason for at the time but I'm pretty sure something changed and it's not necessary anymore. It's probably as easy as changing that, though it might place things in unexpected places with the change. I don't have the right tools with me to look into it any further as I'm away from home this week but will take a look when I'm back :slightly_smiling_face:.

If possible, is the order added the best order? I'd think this is better than alphabetically.

hartenthaler commented 4 months ago

I would prefer to see the newest ones first.

Neriderc commented 4 months ago

I would prefer to see the newest ones first.

Currently the field to add a record is underneath the list. With oldest first, the new record appears at the bottom just above the box where you add it, so you can see it's been added. Would you prefer it was added to the top, and the rest of the process stays the same?

schuco commented 4 months ago

In my case I mainly store settings grouped by family, like Br01Overview, Br02Farmowners, Kh01Overview, Kh02Founders, ... So in my case alphabetical order would be best. In case only newest/oldest is possible I would prefere to see the newest entry at the bottom.

Neriderc commented 4 months ago

Somehow I knew this conversation would lead to adding a new option for sort order 🙂

I'm home again now so will try to find some time to dive into this.

Neriderc commented 4 months ago

On second thought, I should work on the changes to how settings are saved first.

Just to make sure I have this right when I come back to it, here's my understanding of what we want to do:

schuco commented 4 months ago

As far as I understand that is o.k.

Neriderc commented 4 months ago

This is now done :slightly_smiling_face:

You can test it by updated to the main branch. I haven't seen any issues with it, and I have tested using it with old settings mixed with the ones updated with a date. But it may be a good idea to export your settings to files as a backup if they are important.

hartenthaler commented 4 months ago

The translations are done. The test was successful. Thank you!