Closed Neriderc closed 3 months ago
I've finished this functionality. In the end I added a second option next to the option to highlight starting individuals, where you can add XREFs to highlight additional individuals.
I have then added the option to the menu or clicking action to add to this list.
It works fine. There is only a minor matter of wording: In the side menu >appearence > colours there is "show additional individuals in different colours". This should read like "show selected individuals in different colours" because when you click a starting person which is already highlighted due to the regarding option for starting persons this will be highlighted in the colour set by the new extra option. Another problem is that this powerful new option to set colours for selected individuals is "hidden" quite deep in the menu structure. Can the help-funtion be provided somehow with the popup-menu?
There is only a minor matter of wording:
I struggled to find good words for it. I'm happy to update it to 'selected'.
Can the help-function be provided somehow with the popup-menu?
In the place you set the action for clicking on an indvidual, if you click the button to see the help, it tells you about the option to highlight and says where to find the actual setting, pointing you to the help page for that section.
Were you thinking of something like having a help button within the menu? Perhaps there could be an option in the menu "Show help for these options"?
Were you thinking of something like having a help button within the menu? Perhaps there could be an option in the menu "Show help for these options"?
Could you add an "i"-button at the endor below the line "add to list of individuals to highlite" in the popuo menu?
Now we have the option to use two different colours to highlight individuals in the chart, which is fine. But one colour is reserved for starting individuals. Could this become more flexible by adding a box for the highlight colour behind each selected individual in the side menu? Then maybe colouring of starting individuals and selected individuals could be treated in one box instead of in two.
Could you add an "i"-button at the endor below the line "add to list of individuals to highlite" in the popuo menu?
Are you thinking we only need help for that specific option, since it's buried in the settings? Something like this?
Or maybe just an icon for the whole menu, like this?
Or add a whole option to the menu?
Now we have the option to use two different colours to highlight individuals in the chart, which is fine. But one colour is reserved for starting individuals. Could this become more flexible by adding a box for the highlight colour behind each selected individual in the side menu? Then maybe colouring of starting individuals and selected individuals could be treated in one box instead of in two.
Hmm, so you're thinking that we remove the option to highlight starting individuals, create a list of individuals based on the XREFs in the selected individuals option, and then have a colour select next to each individual person?
Or maybe just an icon for the whole menu, like this?
This will do the same as poroposal below
Or add a whole option to the menu?
I think just the icon for the whole menu is sufficient and is consistent to other help-texts.
Hmm, so you're thinking that we remove the option to highlight starting individuals, create a list of individuals based on the XREFs in the selected individuals option, and then have a colour select next to each individual person?
Not really. My idea is like this where the is set behind each of the listed starting- and selected individualsand each can be set toi individual colours
Regarding the "i"-button: I would prefer the second option, placing the button in the top right corner. (What does that look like in RTL languages?)
Not really. My idea is like this where the is set behind each of the listed starting- and selected individualsand each can be set toi individual colours
Is the option to highlight starting individuals necessary anymore, if each individual can be individually coloured? I would think just the option to add selected individuals should be enough. It will be quite easy to add new ones using the menu option, and we should be able to automatically convert old saved settings into the new setup.
Regarding the "i"-button: I would prefer the second option, placing the button in the top right corner. (What does that look like in RTL languages?)
I don't think GVExport is translated into any RTL languages, so it's not easy to test. My guess would be the i would potentially cover some text at the top right. If we ever get translated into an RTL language, we can probably fix it relatively easily once we can test it.
I'll add the i to the top right as suggested.
I'll take a thumbs up as agreeing, so I've created #497 to do these changes.
We should allow the user to highlight individuals in the diagram by adding them to the options for what happens when we click on them (and also the menu, if the option to show a menu is active).
As suggested by @schuco in https://github.com/Neriderc/GVExport/issues/402#issuecomment-2143398881_
We could possibly extend "Highlight starting individuals" to allow XREFs of other individuals to be added, and then have the option add to this list.