search

Neriderc / GVExport

Repository for GVExport module for Webtrees
GNU General Public License v2.0
15 stars 7 forks source link

Abbreviation of country names - support when using already 3 letter ISO codes #538

Open hartenthaler opened 1 week ago

hartenthaler commented 1 week ago

I'm using PLAC entries like "Mengen, Sigmaringen, Baden-Württemberg, DEU". All PLAC in my database already use 3 letter ISO codes as the highest hierarchy level.

It would be helpful if the location abbreviation function would allow me to show such an entry as

Neriderc commented 1 week ago

Oooh, that's an idea. We could run the abbreviation logic backwards to to this. Is there any risk of causing problems if we convert these codes in the city and country option? Would there be a use case where people would want to use the city and country option without converting the ISO codes to the full country name?

I'm just wondering if it's better to be it's own separate option or if it's ok to integrate it into this current option if this won't cause issues for anyone.

hartenthaler commented 1 week ago

There is always the option "Full place name," which should be shown as it is entered in PLAC. I would prefer to integrate it into the existing options. There should be no conflict because the 2- or 3-letter codes differ normally from all the long country names.

If a user (as I) uses "Mengen, Sigmaringen, Baden-Württemberg, DEU" and likes to see "Mengen, DEU" he can select the option "city and ISO 3 letter code". If I have a PLAC like "Isengard, , , Mordor" (ie unknown country) I would expect that in all options containing a country name/code "Mordor" should be shown as country.

To make it more clear you can change "city and country" by "city and long country name". That should not disturb users of "Paris, , , France". They expect to see "Paris, France". It makes it more clear for users like me (using "Paris, , , FRA) that the long country name will be shown (ie "Paris, France").

In the help text, you can emphasise that this option defines what is preferred to be shown, independent of what is used as country in the highest hierarchy level of the PLAC.

Neriderc commented 6 days ago

I'm just wondering if there is ever a situation where someone has deliberately chosen to list some records as FRA and others as France. I can't think of any use case, but I don't like to change how things work without thinking it through.

I agree with you though, it would be best to integrate into the current options. Most likely, anyone who has FRA for some records and France for others probably just took data from different places and now it's messy and needs fixing. If they want to identify such records, they can use the "Full place name" option as you have pointed out.

Let's proceed as you suggest, having this just for the "City and country". I don't think we need to change the name, it can be explained in help text.

If anyone doesn't like this idea they can comment here and let us know then we can consider their use case, otherwise we can make the change as above.