search

Nerogar / OneTrainer

OneTrainer is a one-stop solution for all your stable diffusion training needs.
GNU Affero General Public License v3.0
1.34k stars 110 forks source link

Accessibility fixes #340

Closed mx closed 1 week ago

mx commented 2 weeks ago

This adds scrollbars to every frame that could use them (for people who need much larger, zoomed-in text), and makes pop-out windows resizable (for the same set of people).

Fixes #286 and #329.

Nerogar commented 1 week ago

There are quite a few issues with these changes.

  1. The rows in the additional embedding tab are all way too tall with a lot of blank space between them. (Same issue in the sampling tab)
  2. The mask editing in the CaptionUI (=Dataset Tool) breaks if the window is resized, and the image can be cut off. This one might not be a huge issue, but it's something that should be solved at some point.
  3. The generate caption and mask windows are resizable, but the UI elements within them don't stick to the sides, so you just add more empty space by resizing them.
  4. The advanced sampling window (the three dots on the sampling tab) throws an exception.
mx commented 1 week ago

1 - Fixed, sorry about that, there's no reason those should have scrollbars in the first place (what was causing the issue).

2 - I think this is fixed with my fix for the third point.

3 - Fixed for the image display, but it is admittedly a little quick and dirty (just want to get the functionality there for the users who need to resize it to fit in their smaller monitors).

4 - Fixed.