Closed Wprussell closed 1 month ago
Nerogar
commented
1 month ago 4e07 might not be a useful learning rate for most usecases, but it doesn't make sense to add a validation for this. It's a number just like 4e-07. OneTrainer can't know if you intentionally used a really high learning rate, or if it's a mistake
Wprussell
commented
1 month ago 4e7 and 4e-07 are the same base 10 number. It's just that one trainer thinks that they are different. 4e7 is a hexadecimal as well, and not even in the realm of possibility for this case.
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Nerogar @.> Sent: Monday, September 23, 2024 3:18:19 AM To: Nerogar/OneTrainer @.> Cc: William Russell @.>; Author @.> Subject: Re: [Nerogar/OneTrainer] [Feat]: Add Validation to LR's (Issue #471)
4e07 might not be a useful learning rate for most usecases, but it doesn't make sense to add a validation for this. It's a number just like 4e-07. OneTrainer can't know if you intentionally used a really high learning rate, or if it's a mistake
— Reply to this email directly, view it on GitHubhttps://github.com/Nerogar/OneTrainer/issues/471#issuecomment-2367788994, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BI22TKCWLZWETJCCXJW3YDDZX7TGXAVCNFSM6AAAAABORNCG2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXG44DQOJZGQ. You are receiving this because you authored the thread.Message ID: @.***>
Nerogar
commented
1 month ago 4e7 and 4e-07
no they aren't. 4e7 is the same as 4*10^7, while 4e-7 is 4*10^(-7). they are completely different numbers.
https://en.wikipedia.org/wiki/Scientific_notation
Describe your use-case.
Please please please.
Very simply add validation to learning rates. For example.... I often type... 4e07. Instead of 4e-07 . Immediately leads to nan! Drives me crazy, my brain cannot see that silly "-" no matter how hard I try. I can't tell you the number of times that I've gone to nan because of it.
If it's at all possible, please do us a quality of life adjustment. And if you are bored, do the same in other places. Simple regex validations.
TY for all the hard work!
Cruel_World
What would you like to see as a solution?
See above.
Have you considered alternatives? List them here.
Regex validation.