search

Nerogar / OneTrainer

OneTrainer is a one-stop solution for all your stable diffusion training needs.
GNU Affero General Public License v3.0
1.81k stars 153 forks source link

[Feat]: Dataset masking UI should display a brush outline matching current brush size #569

Open O-J1 opened 1 week ago

O-J1 commented 1 week ago

Describe your use-case.

Dataset masking UI should display a brush outline matching current brush size. Low prio but also likely relatively easy.

What would you like to see as a solution?

A thin circular outline that changes after the user scrolls, matching the current brush size.

Have you considered alternatives? List them here.

N/A

Arcitec commented 1 week ago

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

O-J1 commented 1 week ago

I agree it would be nice. But we are at the mercy of TkInter and CustomTkInter GUI toolkits which have no features at all for image editing, and may not even have custom cursor support, so I don't think this is easy or maybe even doable.

We don't have a brush. Everything about the current mask editor is faked by just catching the click event and coordinates. 😉

I’m aware of what we are using, you don’t need to tell me don’t worry. This isn’t my request either, it’s a transferred user request. As for doability, I made an extremely shitty version and it worked. So my assessment is from that 👍