Next enhancement ?

[alexisju]

Maybe you need to add some CSS (to the object class .emojione): no problem to have unicode emoji (ie 🌴) converted into image (🌴), but if you use shortname (ie :palm_tree:), the emoji converted is very big (100% svg size).

Do you plan already some enhancements, like :

• ascii smilies conversion (http://git.emojione.com/demos/2.1.4/ascii-smileys.html)
• shortcode autocomplete (http://git.emojione.com/demos/2.1.4/autocomplete.html) (without that we need to copy/paste unicode emojis from other websites or memorise shortcodes, what is not very convenient).

[Copy/pasted feedback from https://github.com/shaarli/Shaarli/issues/545#issuecomment-214775453 )

[NerosTie]

The issue with shortname is fixed, can you try?

[alexisju]

Right! Fixed :-)

[NerosTie]

ASCII conversion works. Can you try? But be aware, you can't have a smiley alone on a line.

To activate it, change false to true in emojione.js

[alexisju]

It work (but in dont understand your warning).

[NerosTie]

If you put a smiley alone, like this:

:)

It will not be converted.

[alexisju]

On my instance, both works

[NerosTie]

Not me, weird...

The autocomplete.js is huge! 250 Ko :worried:

[alexisju]

Maybe it is better to not include it into this plugin (for people like you using browser plugin), but create another plugin to load if people need it? (or make a custom version with less autocomplete sugestion) ?

You can also simple add in the readme some exemple to Firefox/Chrome addons...

[NerosTie]

It works! And I like it. Even on a smartphone, it's pretty cool.

But unfortunately, this is big! The autocomplete.js itself is big but you also need 2 external jquery javascripts as dependencies...

385 Ko for the all thing.

Also, it works only in the Description area. It could be nice to have it in the Tags area too.

Is it worth it to have a separate plugin? Or just one plugin but I comment the whole thing about autocomplete?

[alexisju]

Minified version of js can reduce size and improve loading time ?

[alexisju]

It seems autocomplete could also work with zepto.js (9 ko) instead jquery.

and jquery.textcomplete.min.js 18.4 KB

Minified version of autocomplete is around 230 ko

[NerosTie]

And around 50 Ko if gzipped (with closure)

Do you think it's better to have everything self-hosted? Or is it ok to call them from the outside?

[alexisju]

Personnaly i prefer to have all librairies self-hosted. It is not a performance matter but about privacy and tracking.

[NerosTie]

Well, it works even without jquery. So we can delete it.

So now the question is: 230ko, is it too big for this plugin?

[alexisju]

I don't know, i think it is not too much (if loadded in footer). The scripts just need to be loaded once, after the browser keep it in the cache.

[NerosTie]

Ok, let's try then. I will self-host emojione.min.js too (188ko). Gzipped, it should be ok. If people complain I will see. The only thin that I can't self-host are the svg and the png, this is way too big.

But I will comment the autocomplete, because maybe not everybody will like it.

Also, can you tell me what happen if you put a shortname as a tag?

[alexisju]

(By self hosting, i mean to included into this repository; each shaarli instance is self hosted)

[NerosTie]

Yes, this is my definition of self-hosting too.

[NerosTie]

New version is out!

Don't forget to edit emojione.php and js/emojione.js to activate all the functions.

Tell me what you think and can you tell me what happen if you put a shortname as a tag?

[alexisju]

Broken!

You need to put emojione.min.js before emojione.js to render emojis

I don't get autocomplete

Bonus: .dropdown-menu css alterate my shaarli's template (albinomouse). They use the same class' name.

[NerosTie]

Not broken anymore :wink:

[NerosTie]

For .dropdown-menu, I have to edit autocomplete.css and textcomplete.min.js. I don't like this idea for future updates (they are unmodified versions of the originals).

[alexisju]

Ok, not broken anymore, but autocomplete still not working.

[NerosTie]

It works for me. But I have jquery with my theme. Maybe it doesn't work with zepto.js.

Can you comment the line with zepto.js in emojione.php and add this instead: $data['js_files'][] = 'https://code.jquery.com/jquery-2.2.3.min.js';

And tell me if it works.

[alexisju]

I just tryed, but it didnt work.

However, in same time i have weird things. The plugin seems no work anymore on my instance..

I don't understand why. I cleared the tmp files.. and tryed on another test instance.. without better result.

[NerosTie]

You say it works with jquery but in the same time the plugin do no work anymore? I don't understand.

[alexisju]

Sorry it didnt.

[alexisju]

Ok i know why. I desactivated markdown plugin.

[NerosTie]

Well, autocomplete do not work with the default theme either... (I'm using the material theme)

[alexisju]

(i'm doing my test with default template ;) )

[NerosTie]

Ha! That's why! Unfortunately, I have no solution in mind :disappointed:

[alexisju]

Using awesomplete (shaarli's autocomplete js for tags) ?

[NerosTie]

I don't understand your question.

[alexisju]

Awesomplete (http://leaverou.github.io/awesomplete/) is the js library used by shaarli to suggest (and autocomplete) tags. Maybe it could be used also the the emoji's shortcode list ?

[NerosTie]

It would be more complicated to implement it, I think. Autocomplete seems to be more powerful for emojis than awesomplete would be. With autocomplete, you can search :food which is not an emoji but a tag for a family of emojis.

But there are other bugs: https://github.com/NerosTie/emojione/issues

[alexisju]

Ok, for now i can use browser addon :-) Its fine too

[NerosTie]

What do you call "browser addon"?

[alexisju]

However, if autocomplete is broken with defaut shaarli, maybe it is better to have a "clean" plugin which just enable emoji (and another plugin to enable autocomplete in your theme).

At least comment also $data['css_files'][] = PluginManager::$PLUGINS_PATH . '/emojione/css/autocomplete.css'; by defaut

Browser addon: Firefox/Chrome extension

[alexisju]

Another thing, if you fix autocomplete : maybe it is better if the autocomplete can insert unicode emoji (not shortcode), it will fit better in RSS or if we disable the plugin.

[NerosTie]

Ok, for now i can use browser addon :-) Its fine too

Autocomplete do not work with the theme you use but it works with the browser addon? The extension on chrome is basically a page in html.

maybe it is better to have a "clean" plugin which just enable emoji (and another plugin to enable autocomplete in your theme).

It's not supposed to be broken forever :wink:. I will let the autocomplete and ASCII Smiley commented for now. To have them in option it's a good solution, I think.

Another thing, if you fix autocomplete : maybe it is better if the autocomplete can insert unicode emoji (not shortcode), it will fit better in RSS or if we disable the plugin.

Autocomplete is based on shortnames, so I don't think it will be easy to change it. But I agree, for RSS it would be better. That's why I'm reticent to use shortnames for now. (but a good RSS aggregator could have an addon for emojione too :smile: )

[alexisju]

Autocomplete do not work with the theme you use but it works with the browser addon?

This extension work very well : http://johannh.me/emoji-helper/

[NerosTie]

Use this: https://chrome.google.com/webstore/detail/emoji-keyboard-2016-by-em/ipdjnhgkpapgippgcgkfcbpdpcgifncb

This is better, and it's the official plugin for emojione :)

[NerosTie]

I'm closing this issue. The bug is fixed and all the enhancements are implemented even if some work is needed to have a full compatibility with the most famous themes. Feel free to open a new thread but only for specifics issues, please.