NervanaSystems / ngraph-mxnet

MXNet - nGraph integration
Apache License 2.0
34 stars 3 forks source link

Have bridge code use `origin_node_->attrs.parsed` instead of `origin_node_->attrs.dict` #250

Open cconvey opened 6 years ago

cconvey commented 6 years ago

E.g., in src/ngraph/ngraph_graph.cc:

#include "../../src/operator/nn/deconvolution-inl.h"
...
const auto & op_params = dmlc::get<mxnet::op::DeconvolutionParam>(orig_node_->attrs.parsed);
... op_params.stride ...

We can use this approach for all new bridge code, and optionally revise existing bridge code to use this approach.

Pros:

Cons:

mbrookhart commented 6 years ago

I think we need to do this, but we also need to refactor the ops into multiple files to isolate the includes at the same time.