Nerwyn
commented
1 month ago Alternatively, I can introduce just the template field to custom actions and make it so that any custom action can be used as a template using this deep merge function:
custom_actions:
webostv:
tap_action:
haptics: {{ is_state(‘media_player.lg_smart_tv’, ‘on’) }}
action: |
{% if is_state(‘media_player.lg_smart_tv’, ‘on’) %}
call-service
{% else %}
none
{% endif %}
service: webostv.button
target:
entity_id: media_player.lg_smart_tv
left:
template: webostv
tap_action:
data:
command: LEFT
right:
template: webostv
tap_action:
data:
command: RIGHTfunction mergeDeep(target: object, ...sources: [object]) {
function isObject(item: object) {
return (item && typeof item === 'object' && !Array.isArray(item));
}
if (!sources.length) {
return target;
}
const source: object = sources.shift() as object;
if (isObject(target) && isObject(source)) {
for (const key in source) {
if (isObject(source[key as keyof object])) {
if (!target[key as keyof object]) Object.assign(target, { [key]: {} });
mergeDeep(target[key as keyof object], source[key as keyof object]);
} else {
Object.assign(target, { [key]: source[key as keyof object] });
}
}
}
return mergeDeep(target, ...sources);
}
for (const key in customActions) {
if (customActions[key].template) {
const template = structuredClone(customActions[customActions[key].template])
customActions[key] = mergeDeep(template, customActions[key])
}
}It may bit a little bit before I get to actually implementing this.
Javerre
Is your feature request related to a problem? Please describe. I wish to use your excellent remote card to control an LG WebOS TV. The integration for that does not have a “remote” entity, but a “media_player” entity. Furthermore all key presses must call the “webostv.button” service. I would also like to disable the buttons when the TV is off.
All this can already be done using android-tv-card but it requires a huge amount of configuration, which is then fragile and error prone.
Describe the solution you'd like I would like you to implement button templates to simplify the configuration YAML. Take a look at how this is done in the button-card plugin, which I have found to be very effective and concise.
I think the best way to do this would be to introduce “template” and “variable” options for each button in the “custom_actions:” section. The “template” option would refer to action templates a globally defined action template where the details for button actions can be specified once, parametrised by any values set in the “variables” option. For example:
Describe alternatives you've considered I can implement a lot of the functionality I need using “button-card” but I would lose the touchpad feature which is what I really want. Alternatively I can just grit my teeth and copy/paste/edit a couple of hundred lines of YAML and use android-tv-card.
Additional context I think this would greatly enhance the functionality of android-tv-card and reduce the demand to add support for new integrations. Furthermore, no change to core functionality would be required, just to the code that reads and interprets the configuration.