Nerwyn / material-rounded-theme

A Material You and Google Home app influenced theme for Home Assistant
Apache License 2.0
77 stars 8 forks source link

Dashboard title overlapping with menu icon #25

Closed ZOXSOCKS closed 1 month ago

ZOXSOCKS commented 1 month ago

Checklist:

Release with the issue: 2.1.0-beta.003

Browser and Operating System: Home assistant companion app Vivaldi (chromium) Android 14 Pixel 7 Pro 1440 x 3120 resolution

Description of problem: The title of the dashboard pops under the navigation drawer menu icon on the mobile browser. (And on desktop browser with the window resized to a mobile resolution).

Title of the dashboard also visibly pops under the menu icon on page load.

Page title should sit next to the menu icon, not under it.

Screenshot_20240729-083241

https://github.com/user-attachments/assets/bf7757ac-ac6e-4577-b36d-59853fa84901

Nerwyn commented 1 month ago

How are you making the dashboard title appear on non subviews? It doesn't appear on any of my lovelace or sections views.

ZOXSOCKS commented 1 month ago

It's taking it from the title of the dashboard. If I change the title, it changes it on the dashboard, and keeps it buried under the menu button.

Screenshot_20240729-144511

Nerwyn commented 1 month ago

That's weird. My title's don't appear. Which version of the frontend are you on? Has it always been like this?

ZOXSOCKS commented 1 month ago

I am on the very latest of everything HA. It might be because I'm using the sections layout rather than anything else?

Nerwyn commented 1 month ago

Nope, I'm also using sections view now. Are you sure it isn't caused by another add-on?

Nerwyn commented 1 month ago

I'm not seeing the view title in the view itself in the Home Assistant docs either. https://www.home-assistant.io/dashboards/sections/

ZOXSOCKS commented 1 month ago

I've figured out the cause of the problem. I have, at present, only one view (and one sub-view which doesn't appear on the nav bar.)

Adding a second view (just named it test for now) moves the 'home' text from the top left and puts it in the bottom nav bar where it belongs. Very odd behaviour! image

Nerwyn commented 1 month ago

Ah I see. That's still definitely worth fixing. I'll try to get around to it later today.

Nerwyn commented 1 month ago

I've put out another beta that should fix this. I ended up reworking and further separating our the header and footer styles and adding padding to the top to make it so that the view no longer overlaps with the header. This does make the view much smaller than default, but it's similar to how most material 3 apps are.

TODO - new screenshots

xvlw commented 1 month ago

This solved an issue I had where the chip card was being covered by the hamburger on the left side on mobile devices. I was forced to add a title to my top section in order to force everything down.

Now I can remove that title and everything fits.

Beta working well for me, thank you!

Nerwyn commented 1 month ago

Fixed in 2.1.0