Closed weixiao-huang closed 2 years ago
Hi, could you please resolve the merge conflicts?
All conflicts have been resolved
Merging #327 (52627eb) into main (392e397) will decrease coverage by
0.15%
. The diff coverage is0.00%
.:exclamation: Current head 52627eb differs from pull request most recent head 5bc0bb5. Consider uploading reports for the commit 5bc0bb5 to get more accurate results
@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 76.60% 76.44% -0.16%
==========================================
Files 4 4
Lines 1962 1966 +4
==========================================
Hits 1503 1503
- Misses 319 323 +4
Partials 140 140
Impacted Files | Coverage Δ | |
---|---|---|
client.go | 74.63% <0.00%> (-0.17%) |
:arrow_down: |
models.go | 92.80% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 392e397...5bc0bb5. Read the comment docs.
Hi again :)
The code looks good so far. Could you please also add a test for that function? :)
I added tests but I cannot test it in my local machine, so please approve the test ci, thanks
Hello, could you please approve the ci to test?
Hi @Nerzal can you take a look into this change? Thank you!
LGTM thank you for the contribution! I'll create a new Release this week, which includes all PRs i merged during the last days
Thanks for your contribution! Hi, if there is an issue, that your PR adresses, please link it!