search

Nerzal / gocloak

golang keycloak client
Apache License 2.0
1.03k stars 283 forks source link

feat: add requiredActionProviderRepresentation #339

Closed shibumi closed 2 years ago

shibumi commented 2 years ago

This commit adds the requiredActionProviderRepresentation and a function for updating required actions

shibumi commented 2 years ago

Code is tested and works for me

Nerzal commented 2 years ago

Hi, could you please also add a unit/integration test for that? :)

codecov[bot] commented 2 years ago

Codecov Report

Merging #339 (1665642) into main (76b1bd1) will decrease coverage by 0.05%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   76.60%   76.54%   -0.06%     
==========================================
  Files           4        4              
  Lines        1962     1970       +8     
==========================================
+ Hits         1503     1508       +5     
- Misses        319      321       +2     
- Partials      140      141       +1
Impacted Files Coverage Δ
models.go 92.14% <0.00%> (-0.67%) :arrow_down:
client.go 74.78% <71.42%> (-0.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76b1bd1...1665642. Read the comment docs.

shibumi commented 2 years ago

@Nerzal yeah sure. Let me have a look on this :D

shibumi commented 2 years ago

@Nerzal updated.. let me know if you want more sophisticated tests

Nerzal commented 2 years ago

Thank you for the contribution! I'll do now merge. It might take a day or 2 until i release a new tag, as there is also a little breaking change in the pipeline.

I'll create a new Release + Tag as soon as that one is also merged.