Nerzal / gocloak

golang keycloak client

Apache License 2.0

1.03k stars 283 forks source link

fix: json tags in GetEventsParams (#335) #340

Closed tjarkmeyer closed 2 years ago

tjarkmeyer commented 2 years ago

This PR addresses the issue https://github.com/Nerzal/gocloak/issues/335

Nerzal commented 2 years ago

HI thank you for the contribution!

Do you know if that is keycloak version dependent in any kind?

Nerzal commented 2 years ago

Also i'll need to check whats wrong with the pipeline

tjarkmeyer commented 2 years ago

I have checked the Keycloak API specification. The change is not dependent on the Keycloak version.

Keycloak expects an 32 bit integer, but since those values are query parameters they are converted to strings anyway.

I have successfully tested it locally with version 15 and 16.

Nerzal commented 2 years ago

Hi again :) Sorry took me a while to look into the pipeline. The linter should have ignored the test file.

Could please merge the current main branch into your branch? That should fix the issue with the pipeline

codecov[bot] commented 2 years ago

Codecov Report

Merging #340 (24bbef6) into main (b55ab25) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files           4        4           
  Lines        1973     1973           
=======================================
  Hits         1515     1515           
  Misses        317      317           
  Partials      141      141

Impacted Files	Coverage Δ
models.go	`92.08% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b55ab25...24bbef6. Read the comment docs.

Nerzal commented 2 years ago

thank you for the contribution. I'll create a new release now