Nerzal / gocloak

golang keycloak client
Apache License 2.0
1.01k stars 277 forks source link

Added APIs to support fine-grained authorization #432

Closed dmartinol closed 1 year ago

dmartinol commented 1 year ago

See issue #431

dmartinol commented 1 year ago

Hi, could anyone have a look at this PR?

Nerzal commented 1 year ago

The tests fail cause of a linter warning. Could you fix that?

Nerzal commented 1 year ago

Thank you for the contribution! Could you also add 1 test case per new function?

codecov[bot] commented 1 year ago

Codecov Report

Merging #432 (d7c3b29) into main (166f442) will decrease coverage by 1.66%. The diff coverage is 0.00%.

:exclamation: Current head d7c3b29 differs from pull request most recent head 19f8418. Consider uploading reports for the commit 19f8418 to get more accurate results

@@            Coverage Diff             @@
##             main     #432      +/-   ##
==========================================
- Coverage   77.25%   75.60%   -1.66%     
==========================================
  Files           4        4              
  Lines        2198     2246      +48     
==========================================
  Hits         1698     1698              
- Misses        338      386      +48     
  Partials      162      162              
Impacted Files Coverage Δ
client.go 73.99% <0.00%> (-1.79%) :arrow_down:
models.go 90.32% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dmartinol commented 1 year ago

Thank you for the contribution! Could you also add 1 test case per new function?

I added 2 and the coverage should increase, can you try?

Nerzal commented 1 year ago

LGTM, thank you for the contribution!

dmartinol commented 1 year ago

LGTM, thank you for the contribution!

Thanks to you for maintaining this amazing client! BTW: are you planning to create a new release soon, so we can integrate it in our application?