Closed robbert229 closed 11 months ago
Hi! Thank you for your contribution. Although unrelated to your changes, could you pls check if there is an update available for the "pkg:golang/golang.org/x/net@v0.7.0" dependency and if so update it in go.mod?
The pipeline is failing due to a security issue in that version.
I can do that. :)
@Nerzal fyi i think everything is done on my side.
Build is failing due to CVE released two days ago with the net package. ~Do you want me to update the package again?~
I updated the net package again
Merging #446 (8ef820f) into main (166f442) will increase coverage by
0.01%
. Report is 3 commits behind head on main. The diff coverage is77.77%
.
@@ Coverage Diff @@
## main #446 +/- ##
==========================================
+ Coverage 77.25% 77.26% +0.01%
==========================================
Files 4 4
Lines 2198 2261 +63
==========================================
+ Hits 1698 1747 +49
- Misses 338 345 +7
- Partials 162 169 +7
Files | Coverage Δ | |
---|---|---|
models.go | 90.38% <100.00%> (+0.06%) |
:arrow_up: |
client.go | 75.82% <77.41%> (+0.04%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR upgrades golang-jwt to the newest v5 version. The upgrade is pretty convenient as v4 has some painful bugs such as https://github.com/golang-jwt/jwt/issues/98 which are resolved in v5.