Nerzal / gocloak

golang keycloak client
Apache License 2.0
1.01k stars 275 forks source link

use path.Join in makeURL #468

Closed john-behm-bertelsmann closed 5 months ago

john-behm-bertelsmann commented 5 months ago

Hi,

I have com across the "problem" that when you provide a keycloak base url that ends with a trailing slash, that the library does not properly concatenate the url paths. My suggestion is to use path.Join instead of strings.Join(..., "/")

https://github.com/Nerzal/gocloak/blob/fec0d9efa6d0bcb06e3f475fb4672790ec16fee0/client.go#L47-L49