Neseek77 / gwt-facebook

Automatically exported from code.google.com/p/gwt-facebook
1 stars 0 forks source link

class FbPromprPermission has hardcoded permissions, needs generalized case #2

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. want to prompt the user for any combination of permissions
2.
3.

What is the expected...?
I expected to be able to use any combination of Enum FacebookApi.Permission 
when constructing the control.

What version of the product are you using? On what operating system?
1.0-BETA6
Checked out October 28, 2009 11:49:02 AM

Please provide any additional information below.
Original class code is very simple and probably made for a specific use 
case. Unfortunately its doesn't match the use case I'm working on.

public class FbPromptPermission extends ComplexPanel {

    public FbPromptPermission () {
        setElement ( DOM.createElement("fb:prompt-permission" ) ) ;
        getElement().setAttribute("perms", 
"read_stream,publish_stream");

        addStyleName ("gwittit-FbPromptPermission" );

        add ( new HTML ( "Grant permission for status updates" ), 
getElement() );
    }
}

Original issue reported on code.google.com by andy.stevko on 29 Oct 2009 at 6:26

GoogleCodeExporter commented 9 years ago
will fix this soon !

Original comment by olama...@gmail.com on 29 Oct 2009 at 12:50

GoogleCodeExporter commented 9 years ago
no worries, its not a blocker. Just wanted to start the conversation.
I'm glad to have this library as a starter for my project although it is still 
a bit 
rough. While trying to use it I've raised some questions about how it works. 
I'm familiar with FBML, rest and soap while doing the same thing in jsp.
Mind if I contribute some upgrades and contribute to the wiki?

Original comment by andy.stevko on 29 Oct 2009 at 3:46

GoogleCodeExporter commented 9 years ago
fixed it: ) 
see source 
http://code.google.com/p/gwt-facebook/source/browse/trunk/GwittIt/src/com/gwitti
t/client/facebook/xfbml/FbPromptPermission.java

updated the showcase app as well, http://gwittit.appspot.com  ( XFBML menu item 
)

Original comment by olama...@gmail.com on 29 Oct 2009 at 10:41

GoogleCodeExporter commented 9 years ago
hello,

How can we add a new permission friends_photos .
Itseems from the above file the below  are the only valid permissions 

 Valid permissions email, read_stream, publish_stream, offline_access,
 * status_update, photo_upload, create_event, rsvp_event, sms, video_upload,
 * create_note, share_item.

Thanks,
Maruti

Original comment by maruthi....@gmail.com on 28 Apr 2011 at 1:02