url can be null

[GoogleCodeExporter]

What steps will reproduce the problem?
1. disable demo mode
2. choose openID
3. delete http:// from text field
4. Open Firebug (or equivalent) in debug mode
5. Click Sign in

What is the expected output? What do you see instead?
Expected: Nothing
Seeing: url is null error in Line 120 of openid-jquery.js:

if (url.indexOf("javascript:") == 0) {

What version of the product are you using? On what operating system?

1.3, any OS

Please provide any additional information below.

Fix is:
if (url && url.indexOf("javascript:") == 0) {

Original issue reported on code.google.com by jos...@feth.com on 15 Aug 2011 at 8:29

[GoogleCodeExporter]

I hit the same bug, although my solution was different. The source of the 
problem is the url for the generic openid provider. The following diff is 
against openid-selector-1.3. The same fix should be applied to other languages 
as well.

--- a/media/openid-selector/js/openid-en.js
+++ b/media/openid-selector/js/openid-en.js
@@ -27,7 +27,7 @@ var providers_large = {
    openid : {
        name : 'OpenID',
        label : 'Enter your OpenID.',
-       url : null
+       url : ""
    }
 };

Original comment by guyruten...@gmail.com on 20 Aug 2011 at 2:05

[GoogleCodeExporter]

agreed, your fix is more solid.

Original comment by jos...@feth.com on 20 Aug 2011 at 2:08

[GoogleCodeExporter]

already fixed in SVN trunk
see http://code.google.com/p/openid-selector/source/detail?r=155

Original comment by andriy.gerasika on 20 Oct 2011 at 10:26

• Changed state: Done