Closed GoogleCodeExporter closed 9 years ago
I have resolve this issue.
Files with a patch and new pictures are attached to this message.
Suddenly I don't know how to include binary files into the patch correctly, so
I have decided just to attach them. Their place to copy is:
${openmeetings_dir}\WebContent\openmeetings\modules\conference\video\resources\
I also have attached a screenshot with a result of my work.
Original comment by german.g...@gmail.com
on 8 Sep 2011 at 4:14
Attachments:
UPD: these binary files are mirco_on.png and micro_off.png
Original comment by german.g...@gmail.com
on 8 Sep 2011 at 4:16
This issue was closed by revision r4245.
Original comment by solomax...@gmail.com
on 16 Sep 2011 at 4:42
Does this Issue mute only remote hosts or also self?
Because it is a difference if you click on "mute" if you want to mute yourself
compared to mute other users.
Will the mute-button, mute it only on the current screen or for all screens?
Original comment by seba.wag...@gmail.com
on 16 Sep 2011 at 7:20
Original comment by seba.wag...@gmail.com
on 16 Sep 2011 at 7:21
This button mutes/unmutes a microphone of any chosen user. So, if you are a
moderator then you can mute/unmute someboby's microphone.
But if you are a simple user then you can mute/unmute only yours.
Original comment by german.g...@gmail.com
on 16 Sep 2011 at 8:26
That sounds great :)
Original comment by seba.wag...@gmail.com
on 16 Sep 2011 at 8:33
Okay well we will have to rework that a bit:
The "mute others" ... its misleading ... this exclusive thing should be more
clear. We will refactor to have mute + unmute to have that in the user-list
too.
And the "give exclusive audio" is actually another way of muting people.
Currently the "Exclusive Audio" Icon does not change at all in the user list
(at least looking at the restricted roomtype) no matter what status the user
has, mute or unmuted.
The init-status of the unmute/mute function has at least to the icons no effect.
If you initialize the list of users, where some users are ALREADY muted:
1) The icon has to show the right status!
2) The user REALLY needs to be muted!
=> There is no way of doing this only at runtime / for those that are already
in the room that will lead to situations where on one screen people are
un-muted while on others same persons are muted.
This attribute needs the hole cycle, just like any other "rights" like
"allowScreensharing" "allowRemoteControl" et cetera ...
I will try to rework it now and commit my proposal for discussion.
Thanks for your hard work, now we only need to polish it a bit :))
Original comment by seba.wag...@gmail.com
on 17 Sep 2011 at 9:00
actually this should be the title of the issue then.
Original comment by seba.wag...@gmail.com
on 17 Sep 2011 at 12:34
I have commited a fix to have the possibility to mute a user from the user-list
in the room-type restricted in r4248. Please have a look at it.
The *exclusive audio* has went out for now cause first of all the mute
functionality really has to work on all roomtype.
I have planned that the moderator can mute from the user-list for all screen.
But the user itself can still mute or unmute a single video pod locally (so
without snycing to others) However if the moderator has muted anybody the user
can of course not unmute it. (This functionality for "local muting" is to be
done too).
As well as the "exclusive audio" will become an additional function of the mute
button in the user-list. But as explained => first of all the mute
functionality has to work everywhere.
Original comment by seba.wag...@gmail.com
on 17 Sep 2011 at 3:19
I have tried it and found a problem with this implemetation.
I have opened two openmeetings windows at Google Chrome and Mozilla Firfox
browsers. Then I have logged in using different accounts and have gone into the
restricted room.
So, when I try to mute a microphone of one or another user then it mutes them
both. Microphone icons are changed for both users at video-windows and both
microphones are muted. But at the user list it is changed correctly.
At my initially implementation there is no such problem (microphones are not
muted both).
I suspect that it is a very little and easy solvable mistake. So, good luck
with fixing of it! :)
Original comment by german.g...@gmail.com
on 19 Sep 2011 at 4:53
Hi,
thanks for reviewing it, which revision did you test?
*So, when I try to mute a microphone*
=> did you click on the microphone in the video pod or on the microphone in the
user list or in the microphone in the status icon bar?
Was the user that mutes the video a moderator?
Was the user that mutes the video muting another user or muting his/herself?
Thanks
Sebastian
Original comment by seba.wag...@gmail.com
on 19 Sep 2011 at 8:56
Sebastian, I have checked it using the last version from svn (revision 4265).
Here is the scenario:
1) open OpenMeetings in two browsers (I do it using Chrome and Firefox)
2) log in using different accounts (I do it choosing an administrator user and
a simple user)
3) enter to the restricted room and allow the simple user publish his
video/audio by the administrator. And also make it for the administrator by
himself
// simple user sees the mute button on each video window. Is it correct?
4) Simple user: click on mute-button on his video window than press "ok" in the
appeared dialog
// now both microphones on both video windows are crossed. It is a mistake I
think
// but if you look at the user list by the administrator then you will see that
there are correct microphones' pictures in the list.
5) Simple user: click on that mute-button again
// now both microphones are not crossed on both video button
Using another button (on the top of the user list) by the simple user has the
same behavior.
Original comment by german.g...@gmail.com
on 20 Sep 2011 at 4:12
Hi German,
thank you for the review.
Maybe my logic is not that clear too: Did you notice the popup window message
and how I difference between *local mute* and *global mute*.
*simple user sees the mute button on each video window. Is it correct?*
=> yes a simple user can:
1) Mute other users *locally* meaning he can mute them on his screen.
2) He can still mute his own audio... Because he could always mute himself just
be choosing different device settings it makes no sense from my point of view
to prevent anybody from muting the own audio.
*now both microphones on both video windows are crossed.*
=> That should not happen I will look into that again.
*now both microphones are not crossed on both video button*
=> same again, I should look at this issue again.
==> After all: I think my logic with local muting is too complex. We will hide
the mute button for non moderators.
I think the really important thing todo to handle this is to add a button "mute
all" "unmute all" or something like you've done "give exclusive audio".
I see the most important use-case / scenario is:
The moderator wants to say something and to mute everybody, except him.
The second most important use-case / scenario is:
The moderator wants to give exclusive audio to somebody.
=> Both could be solved by your exclusive audio button. The question is just
how to put that into the UI without making it too complex to handle.
The mute buttons do give a good visual feedback now to see who is muted. Now we
need to find a place for the exclusive thing. Maybe we put that button just
into the video pod.
@German: Did you also test / experiment with setting different "gain" values to
the micro? Another useful logic would be to make people louder by setting
different gain values to their audio.
Thanks for your reviews German.
Original comment by seba.wag...@gmail.com
on 20 Sep 2011 at 7:26
Ok, I understand this logic, so these my notes are not bugs. But yes, it is so
complex for simple users. And implementation of these two scenarios would be
more understandable.
Yes, I used setting different gain values to the micro in my implementation.
Alexey Fedotov tells that setting different gain values of AUDIO breaks the
conference goal: let people communicate to each other. For example, some user
switched off the audio of another user locally (on the first user's computer).
So, if the last wants to tell something to the first he could not do it.
Because he can't switch on his audio on the first user's computer.
But he always can switch on/off his own microphone.
Original comment by german.g...@gmail.com
on 21 Sep 2011 at 5:46
This issue should be fixed in r4291.
For the "exclusive microphone" thing we will add a new issue.
Original comment by seba.wag...@gmail.com
on 25 Sep 2011 at 11:19
Original comment by seba.wag...@gmail.com
on 9 Oct 2011 at 1:45
Original issue reported on code.google.com by
german.g...@gmail.com
on 8 Sep 2011 at 3:40