Net-Skip / netskip-app

A humane web browser
GNU General Public License v3.0
1 stars 0 forks source link

Scrolling Behavior Issue on iOS Netskip #1

Open sweetpufferfish opened 5 months ago

sweetpufferfish commented 5 months ago

Description:

Steps To Reproduce:

Expected Behavior:

Actual Behavior:

Environment: iOS version: 17.5.1 Device model: iPhone 12,1 Browser version: 1.1.1

marcprux commented 5 months ago

Thanks for the report. I can reproduce it, and I'll work on getting it fixed for the next release.

marcprux commented 5 months ago

The fix has been submitted to version 1.1.2 of Net Skip. Once it is available, please try it out and let me know if it solved the problem.

Thanks again for the detailed bug report.

sweetpufferfish commented 5 months ago

Thank you for addressing the issue very quickly in version 1.1.2. While the top to bottom scrolling problem has been mitigated, I am still experiencing it on some pages like webkit.org. The problem re-occurs when scrolling down from just above the bottom and then quickly pulling down.

sweetpufferfish commented 5 months ago

I've got very minimal coding experience but enough for me to have taken a closer look at the snippet of code right here containing the changes:

https://github.com/Net-Skip/netskip-app/blob/33d7fa652b9909a259cc2e9fddc384add06344ab/Sources/NetSkip/BrowserTabView.swift#L115-L125

The problem persists as the bottom bar seems to cycle between show and hidden states when the scroller (bounces, hits?) at the bottom of the page. This behavior causes instability and affects the user experience, despite the changes made to the URL bar visibility logic. Perhaps a different approach could be considered. Maybe, a debounce mechanism or some further threshold adjustments.