search

NetAngels / django-webodt

django module to create MS Word, PDF and other types of documents from ODF and HTML templates
http://packages.python.org/django-webodt/
93 stars 52 forks source link

Missing \n in AbiwordODFConverter #11

Closed adamglowacki closed 12 years ago

adamglowacki commented 12 years ago

Method convert() from AbiwordODFConverter seems to produce empty files. I think it is because of no \n character ending command for abiword in 18 line (webodt/converters/abiword.py). Without this \n abiword does not process the file. At least in my case. Sorry if I'm wrong.

imankulov commented 12 years ago

Thank you for the report, Adam. Can you please specify which version of abiword do you use. I will try to reproduce.

adamglowacki commented 12 years ago

I am surprised with such a quick reply. I have abiword 2.8.6 from opensuse.

2012/6/1 Roman Imankulov < reply@reply.github.com

Thank you for the report, Adam. Can you please specify which version of abiword do you use. I will try to reproduce.

Reply to this email directly or view it on GitHub: https://github.com/NetAngels/django-webodt/issues/11#issuecomment-6053226

imankulov commented 12 years ago

Unfortunately, I didn' t manage to build 2.8.6 on my system so I cannot reproduce your bug. The one installed on my computer is 2.9.1, and everything seems to work.

Can you please specify one more thing. Have you tried to add "\n" to the code and succeeded with it? If it really solves your issue, there is no problem for me to make this minor modification. If you didn't try to fix it that way, please try and let me know what is the outcome.

Thank you.

adamglowacki commented 12 years ago

I've tried to use webodt but conversion yielded empty files. I looked into the code and tried to do the same in python shell. I was able to see the stdout of subprocess. When I put just 'convert %s %s %s' ... to communicate, then there was no OK at the end of the abiword output. When I called communicate with 'convert %s %s %s \n' ... I was able to see OK at the end of the output and files were really converted.

2012/6/1 Roman Imankulov < reply@reply.github.com

Unfortunately, I didn' t manage to build 2.8.6 on my system so I cannot reproduce your bug. The one installed on my computer is 2.9.1, and everything seems to work.

Can you please specify one more thing. Have you tried to add "\n" to the code and succeeded with it? If it really solves your issue, there is no problem for me to make this minor modification. If you didn't try to fix it that way, please try and let me know what is the outcome.

Thank you.

Reply to this email directly or view it on GitHub: https://github.com/NetAngels/django-webodt/issues/11#issuecomment-6063964

imankulov commented 12 years ago

Added missing "\n" in 992121d692f62f74d1f616205fa5ad0e18997ad4. Please try it out.

adamglowacki commented 12 years ago

Now it works! Thank you very much.

2012/6/1 Roman Imankulov < reply@reply.github.com

Added missing "\n" in 992121d692f62f74d1f616205fa5ad0e18997ad4. Please try it out.

Reply to this email directly or view it on GitHub: https://github.com/NetAngels/django-webodt/issues/11#issuecomment-6065521

imankulov commented 12 years ago

Thank you for your investigation and fix. I hope you enjoy.