odt lists support - Githubissues

slafs commented 13 years ago

A kind of a hacky way to support list in odt templates. Basically it places the for tag before second common ancestor.

Thanks for a great app!

slafs commented 13 years ago

I also added a converter backend that uses CUPS-PDF printer and OpenOffice to convert documents to PDFs only, which I think is a common use case.

Regards

imankulov commented 13 years ago

Sławek,

Thank you for your amazing contribution. Because your changes touch different parts of application and are not trivial at all, I don't automatically merge them into master, instead I take every commit, review and cherry-pick.

c116ebe : included in master under e27634041239d1ef792f
05dad0d : didn't yet manage to review. I hope to cope with it in 2-3 days from now.
14a06af: has been already fixed
c1d7a64: I have created a new branch named openoffice_pdf_converter.

I have discovered that there is at least one question regarding OpenOfficePDFCoverter backend. The fact that you wait for the end of OpenOffice process doesn't guarantee that document has been already printed at the time of proces ending. This is because all the CUPS does is accepts the task and says "OK, I will print the job as soon as possible". Because of this issue I was forced to add "wait for the file" loop in the codebase and move changesets to a separate branch.

I would ask you to test changesets in branch openoffice_pdf_converter and let me know if something goes wrong in your environment. I hope everything will be OK and I will merge these changes to master.

NetAngels / django-webodt

odt lists support #4