search

NetApp / harvest

Open-metrics endpoint for ONTAP and StorageGRID
https://netapp.github.io/harvest/latest
Apache License 2.0
146 stars 36 forks source link

Harvest grafana import should provide a way to override a dashboard's `allValue` #2952

Closed cgrinds closed 2 months ago

cgrinds commented 3 months ago

In #2599, the cluster variable was changed to use .* as its allValue. Previously, the variable's allValue was null. One of the consequence of setting an allValue to .* is that when there are no results returned for the variable's prom query, the value for that variable will be .* instead of ()

That means panel queries will include results when they shouldn't because they end up sending a query like this:

sum(aggr_space_total{datacenter=~\"\",cluster=~\".*\"})

instead of what they sent before #2599

sum(aggr_space_total{datacenter=~\"\",cluster=~\"()\"})

This doesn't impact Harvest's out-of-the-box dashboards, but does impact customers using bin/grafana import --labels