NetApp / netappdvp

A Docker volume plugin for NetApp storage
96 stars 33 forks source link

RFE: Improve netapp.log logging format #61

Closed dutchiechris closed 7 years ago

dutchiechris commented 7 years ago

As of v1.3 logging with debug: false in the conf file leads to log entries that look like this:

INFO[0000] Using storage driver: solidfire-san
INFO[0000] Using config: {1 solidfire-san false false [] []}
INFO[0000] Starting docker volume plugin with the following options:  port=27609 volume-driver=netapp volumeDir=/var/lib/docker-volumes/netapp

and with debug:true you get this:

time="2017-01-25T13:58:57Z" level=info msg="Using storage driver: solidfire-san"
time="2017-01-25T13:58:57Z" level=info msg="Using config: {1 solidfire-san true false [] []}"
time="2017-01-25T13:58:57Z" level=info msg="Starting docker volume plugin with the following options:" port=27609 volume-driver=netapp volumeDir="/var/lib/docker-volumes/netapp"

Request is:

  1. Use the same logging format regardless of debug level
  2. Ensure entries have a timestamp regardless of debug level
clintonk commented 7 years ago

Thanks for the suggestion, Chris. We already have a user story to improve nDVP logging, and I've captured this request there.

adkerr commented 7 years ago

Internally tracked by US2168

adkerr commented 7 years ago

Fixed in bbcb41d7ce96a4170e24ccccb2986c5423ab27f4