search

NetApp / terraform-provider-netapp-cloudmanager

Terraform provider to create NetAPP OCCM instances, CVO resources, volumes, snapshots, ... in Azure, AWS, GCP.
Mozilla Public License 2.0
17 stars 27 forks source link

Resource/volume : Allow volume comment for CVO volume update #192

Open MostaphaBentaleb opened 7 months ago

MostaphaBentaleb commented 7 months ago

Comment on volumes are already implemented in the provider when creating a new volume but not yet when updating an existing volume . This PR add it into the Volume update logic . The provider already implement all the needed stuff, "volume/comment" is also available in the volume API call according to the official API doc.

One can update an existing volume without comment to add a comment Update an existing volume with a comment to a different comment Update a volume with a comment to a volume without comment

MostaphaBentaleb commented 6 months ago

Added only what would be needed to fill in the changelog. Release version, process and conventions are out of my scope

chuyich commented 6 months ago

This has been released two weeks back on version 24.3.0.

MostaphaBentaleb commented 6 months ago

This has been released two weeks back on version 24.3.0.

24.3.0 does not seem to exist. Two weeks ago a 24.5.0 have been released CHANGELOG history is already broken . Someone need to have a look on it . Feel free to cancel this MR if ever