search

NetApp / terraform-provider-netapp-cloudmanager

Terraform provider to create NetAPP OCCM instances, CVO resources, volumes, snapshots, ... in Azure, AWS, GCP.
Mozilla Public License 2.0
17 stars 27 forks source link

Storage Account name derived from Connector name #68

Closed davetustin closed 2 years ago

davetustin commented 3 years ago

Hi,

When creating a Cloud Connector, a Storage Account is created at the same time. There is currently no way of changing the Storage Account name.

The Storage Account name uses the Cloud Connector name and appends "sa" to the end.

The Cloud Connector name needs to meet the naming conventions of a Storage Account. For example, has to be globally unique, cannot contain hyphens etc.

As an option, can a parameter be added that allows the Storage Account name to be set?

Many thanks Dave

davetustin commented 3 years ago

The other issues with the Storage Account being created as part of the Connector is that there is no control over how the Storage Account is configured.

Security Centre is complaining of Secure transfer to storage accounts not being enabled, the Account kind is general purpose v1 and not v2, public access should be disallowed etc.

If the the Storage Account can be created independently of the Connector, it would be much better.

lonico commented 3 years ago

currently hardcoded through diagnosticsStorageAccountName


            "diagnosticsStorageAccountName": "[concat(toLower(parameters('virtualMachineName')),'sa')]",
            "diagnosticsStorageAccountId": "[concat('Microsoft.Storage/storageAccounts/', variables('diagnosticsStorageAccountName'))]",
            "diagnosticsStorageAccountType": "Standard_LRS",

                "dependsOn": [
                    "[concat('Microsoft.Network/networkInterfaces/', variables('networkInterfaceName'))]",
                    "[concat('Microsoft.Storage/storageAccounts/', variables('diagnosticsStorageAccountName'))]"
                ],
carchi8py commented 2 years ago

We have an internal story DEVOPS-4855 open for this.

chuyich commented 2 years ago

Fixed in 22.2.2