NetApp / trident

Storage orchestrator for containers
Apache License 2.0
759 stars 222 forks source link

Snapmirror-label feature for VolumeSnapshot #449

Open llelik opened 4 years ago

llelik commented 4 years ago

Describe the solution you'd like Snapmirror-label to be added to a snapshot when created

Describe alternatives you've considered

Additional context Snapshot copies are selected by matching their 'snapmirror-label' with the 'snapmirror-label' of one of the rules from the corresponding SnapMirror policy associated with the SnapMirror relationship. All matching Snapshot copies are incrementally transferred to the destination volume. Snapmirror-label is a human readable SnapMirror Label attached with the snapshot. Size of the label can be at most 31 characters. This label will be used by the vaulting system to identify a vaulting scheme. This feature will enhance customer satisfaction when using Trident with Snapmirror technology which a popular case for enterprise environments. The feature is requested by existing NetApp customers.

mgollo commented 3 months ago

This feature would be very useful for our setup. We use VolumeSnapshots for database backups in our OpenShift cluster and want to copy those snapshots to our backup system via SnapMirror. Currently, we have to run a CronJob in the cluster to add the label to our snapshots via NetApp REST API just before the snapmirror schedule kicks in. This leads to a potential race condition if a snapshot is created between the labeling job and the snapmirror sync, as in such cases the snapshot is not picked up by SnapMirror (it actually will never be transferred). If the label was added via a configuration in the VolumeSnapshotClass, it would make our lives much easier.