NetApp / trident

Storage orchestrator for containers
Apache License 2.0
762 stars 222 forks source link

Missing error handling in the code of the storage drivers #816

Closed tksm closed 1 year ago

tksm commented 1 year ago

Describe the bug

We found the following error handlings missing in the code of the storage drivers. Though we've never encountered problems from these in production, I would like to report this just in case.

  1. err from clientAPI.ExportRuleList() in reconcileExportPolicyRules().

https://github.com/NetApp/trident/blob/37b01b8ee97fe50d19d7aeeabebb01411a85fb05/storage_drivers/ontap/ontap_common.go#L363-L365

  1. err from c.ExportPolicyList() in ExportPolicyGetByName().

https://github.com/NetApp/trident/blob/ad517c448cee0faef3c2c2fe81c81b8ca824264d/storage_drivers/ontap/api/ontap_rest.go#L3407-L3408

Environment

gnarl commented 1 year ago

This issue is fixed with commit 7221bdc and will be included in the next major Trident release.