NetApp / trident

Storage orchestrator for containers
Apache License 2.0
761 stars 223 forks source link

Dynamic luks support #850

Open alifelan opened 1 year ago

alifelan commented 1 year ago

Enable setting the luks option in a volume config based on the parameters from the create volume request

To address #849, we followed an approach where we parse the selectors from the create volume request. After that is done, we get the luks selector, and if it has a value, we assigned it to the volume config. To keep previous functionality, if this value is not set, it will be set to the default from the backend in the ontap san driver.

An issue with this approach is that even though in the NetApp luks documentation this same label is used, an user may use a different label instead of luks.

We implemented this to happen specifically right before the ImportVolume to guarantee previous functionality on other methods.