NetApp / trident

Storage orchestrator for containers
Apache License 2.0
762 stars 222 forks source link

permit specifying daemonset and deployment resources #930

Open clementnuss opened 1 month ago

clementnuss commented 1 month ago

Change description

permit specifying trident-controller deployment and trident-node-linux daemonset container resource requests/limits in the TridentOrchestrator spec.

Did you add unit tests? Why not?

Yes, for both modifications of the deployment and daemonset

Does this code need functional testing?

No, I have already tested the functionality locally, and the following works:

Is a code review walkthrough needed? why or why not?

Probably needed, I'm typically not sure whether my modifications to types.go file needs some autogen of some sort.

Should additional test coverage be executed in addition to pre-merge?

don't think so

Does this code need a note in the changelog?

permit specyfing daemonset and deployment resource requests and limits.

Does this code require documentation changes?

don't think so

Additional Information

I was sure whether I should offer the ability to specify the resources for each container of the deployment/daemonset. that would probably amount to 6-7 resources spec, let me know if you want me to implement that.

closes #853

clementnuss commented 1 month ago

just rebased on master. could you consider this ? it's hard to keep PRs open on the long run.