NetAppDocs / astra-control-service

Open-source documentation for NetApp's Astra service
https://docs.netapp.com/us-en/astra-control-service/
3 stars 4 forks source link

Storage classes needs review #123

Closed gabrieltokyo closed 2 years ago

gabrieltokyo commented 2 years ago

Page: Service type, storage classes, and PV size for GKE clusters

The storage classes names needs your review. CVS-Performance storage classes: netapp-cvs-standard --> netapp-cvs-perf-standard netapp-cvs-premium --> netapp-cvs-perf-premium netapp-cvs-extreme --> netapp-cvs-perf-extreme Note: CVS storage class is correct as it is "netapp-cvs-standard"

Adding a couple of shots for your reference:

image image
netapp-mwallis commented 2 years ago

Thanks @gabrieltokyo - and apologies for the delay. I'll get this fix in and ask you to review the change before it goes public.

netapp-mwallis commented 2 years ago

Hi @gabrieltokyo , can you take a look at the below link and let me know if you approve? If so, I'll make this change public. Thanks! https://review.docs.netapp.com/us-en/astra-control-service_mw-hotfix-gh-issues/learn/choose-class-and-size.html

gabrieltokyo commented 2 years ago

Thank you @netapp-mwallis, you will need to roll back the CVS part. Changes at CVS-Performance row are correct. CVS row did not need any change, so you can set it back to netapp-cvs-standard

netapp-mwallis commented 2 years ago

Thanks, @gabrieltokyo - I've reversed the change to the standard CVS storage class. Can you double check at the following link? https://review.docs.netapp.com/us-en/astra-control-service_mw-hotfix-gh-issues/learn/choose-class-and-size.html

netapp-mwallis commented 2 years ago

@gabrieltokyo I've made this change public, since it was a small change. Please let me know if you see any issues. Thanks! https://docs.netapp.com/us-en/astra-control-service/learn/choose-class-and-size.html

gabrieltokyo commented 2 years ago

Thank you @netapp-mwallis the changes are perfect.

Have a nice time!