search

NetBSD / pkgsrc

Automatic conversion of the NetBSD pkgsrc CVS module, use with care
https://www.pkgsrc.org
308 stars 164 forks source link

py-pydicom: New package. #37

Closed eborisch closed 5 years ago

eborisch commented 6 years ago

Not sure if you like new packages submitted via this mechanism, but thought I would give it a shot... It's my first attempt, so please let me know conventions / best practices I've missed.

iamleot commented 6 years ago

Hello Kamil,

Kamil Rytarowski writes:

@@ -0,0 +1,27 @@ +# $NetBSD$ + +DISTNAME= pydicom-1.2.0 +PKGNAME= ${PYPKGPREFIX}-${DISTNAME} +CATEGORIES= graphics python +MASTER_SITES= ${MASTER_SITE_GITHUB:=pydicom/} +GITHUB_PROJECT= pydicom

Does it still work if you drop this line?

I think it will not work because GITHUB_PROJECT by default is PKGBASE.

However, I think that for MASTER_SITES, ${MASTER_SITEPYPI:=p/pydicom/} can be used instead and will avoid to define GITHUB*.

krytarowski commented 6 years ago

GitHub as upstream is good because we can detect easily newer versions with pkglint.

eborisch commented 6 years ago

Hello Kamil, Kamil Rytarowski writes: I think it will not work because GITHUB_PROJECT by default is PKGBASE. However, I think that for MASTER_SITES, ${MASTER_SITEPYPI:=p/pydicom/} can be used instead and will avoid to define GITHUB*.

I started with that approach, but the fetch fails. Not being all that familiar with pkgsrc's internals, I had difficulty tracking down the source of the error, so I aborted and went with the Github download.

bsiegert commented 6 years ago

If the upstream name is pydicom, the package name should be py-dicom, not py-pydicom.

Am Mi., 31. Okt. 2018, 15:16 hat Eric A. Borisch notifications@github.com geschrieben:

Not sure if you like new packages submitted via this mechanism, but thought I would give it a shot... It's my first attempt, so please let me know conventions / best practices I've missed.

You can view, comment on, or merge this pull request online at:

https://github.com/NetBSD/pkgsrc/pull/37 Commit Summary

  • py-pydicom: New package.

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NetBSD/pkgsrc/pull/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AA04GuPigqr-b-4ESAH7C47LAuLNezqwks5uqbCrgaJpZM4YELAN .

iamleot commented 6 years ago

Benny Siegert writes:

If the upstream name is pydicom, the package name should be py-dicom, not py-pydicom.

On pypi it seems that there is also a (probably different and/or older version) py-dicom package so IMHO it would be better to be a bit cacophonic and keep the name as py-pydicom (I think that an older version is present in pkgsrc-wip as wip/py-dicom).

Eric, a possible further (but tiny!) changes, but it would be nice to discuss that before importing:

Possible little nitpicks:

After discussing/addressing these I think that py-pydicom package can be imported!

Thank you!

eborisch commented 6 years ago

On pypi it seems that there is also a (probably different and/or older version) py-dicom package so IMHO it would be better to be a bit cacophonic and keep the name as py-pydicom (I think that an older version is present in pkgsrc-wip as wip/py-dicom).

Yes, they are two distinct packages from the same author designed to enable side-by-side access to the old API during transitions.

eborisch commented 6 years ago

OK. Moved to biology. Fixed stray +x perms. Moved to += for PLIST_SUBST.

Thanks for the reviews. Anything else I missed?

iamleot commented 6 years ago

"Eric A. Borisch" writes:

OK. Moved to biology. Fixed stray +x perms. Moved to += for PLIST_SUBST.

Thanks for the reviews. Anything else I missed?

Nope, that looks good!

I have only changed chmod' with${CHMOD}' and imported it in pkgsrc as biology/py-pydicom.

Thank you very much Eric for packaging it!