NetBSD / pkgsrc

Automatic conversion of the NetBSD pkgsrc CVS module, use with care
https://www.pkgsrc.org
308 stars 164 forks source link

Bump rspamd to 2.5 #60

Closed sjorge closed 4 years ago

sjorge commented 4 years ago

package seems to work fine on illumos, also compiled on netbsd but did not do a full setup.

alarixnia commented 4 years ago
CMake Error at CMakeLists.txt:419 (MESSAGE):
  Your system does not support getaddrinfo call, please consider upgrading it
  to run rspamd
gcc: error: unrecognized command line option '-fuse-ld=lld'; did you mean '-fuse-ld=bfd'?
*** Error code 1

Stop.
make[1]: stopped in /home/nia/pkgsrc/mail/rspamd/work/rspamd-2.5/CMakeFiles/CMakeTmp
gmake: *** [Makefile:121: cmTC_cd509/fast] Error 1
alarixnia commented 4 years ago

Thanks for the PR, but please include a changelog next time.

I'm committing it with this extra patch to fix the build on systems with lld installed.

$NetBSD$

Avoid specifying a custom linker:
gcc: error: unrecognized command line option '-fuse-ld=lld'; did you mean '-fuse-ld=bfd'?

--- cmake/Toolset.cmake.orig    2020-04-01 13:57:55.000000000 +0000
+++ cmake/Toolset.cmake
@@ -41,8 +41,8 @@ endif ()

 option(LINKER_NAME "Linker name or full path")

-find_program(LLD_PATH NAMES "ld.lld" "lld")
-find_program(GOLD_PATH NAMES "ld.gold" "gold")
+#find_program(LLD_PATH NAMES "ld.lld" "lld")
+#find_program(GOLD_PATH NAMES "ld.gold" "gold")

 if(NOT LINKER_NAME)
     if(LLD_PATH)
sjorge commented 4 years ago

@niacat where do I update the changelog?

Odd, I didn't need the extra patch when i tested in netbsd... is lld not installed by default?

alarixnia commented 4 years ago

LLD's not installed by default, unless you build the system in a certain way. I've got the package installed, though...

The next time you send an update you can add the recent contents of work/rspamd-2.5/ChangeLog to the commit message. It's just required as part of the pkgsrc commit message policy - if I commit a package update without including the release's changes I get nagging emails from people (:

sjorge commented 4 years ago

Ah, probably why I did not run into the issue then. And OK just in the commit message. Got it.

~ sjorge

On 18 May 2020, at 13:27, nia notifications@github.com wrote:

 LLD's not installed by default, unless you build the system in a certain way. I've got the package installed, though...

The next time you send an update you can add the recent contents of work/rspamd-2.5/ChangeLog to the commit message. It's just required as part of the pkgsrc commit message policy - if I commit a package update without including the release's changes I get nagging emails from people (:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.