search

NetBSD / pkgsrc

Automatic conversion of the NetBSD pkgsrc CVS module, use with care
https://www.pkgsrc.org
308 stars 164 forks source link

lang/gcc5: Refine the condition to enable multilib #62

Closed bartoszkosiorek closed 4 years ago

bartoszkosiorek commented 4 years ago

Similar changes were made in lang/gcc7: https://github.com/NetBSD/pkgsrc/blob/trunk/lang/gcc7/options.mk#L27

With commit: https://github.com/NetBSD/pkgsrc/commit/7f56fc9a4780042c292812c0cff53482f9a1a061

The issue appear on Ubuntu 20.04 LTS 64 bit

krytarowski commented 4 years ago

What Linux distro is this?

krytarowski commented 4 years ago

IMHO this should be pushed to mk/platform/Linux.mk

https://github.com/NetBSD/pkgsrc/blob/trunk/mk/platform/Linux.mk#L51

krytarowski commented 4 years ago

Alternatively, can you use ${MACHINE_GNU_PLATFORM} in this Makefile?

bartoszkosiorek commented 4 years ago

I have updated description with details.

krytarowski commented 4 years ago

Having this logic in another package does not make it optimal and it can introduce now repetitive code.

bartoszkosiorek commented 4 years ago

@krytarowski I have created new Pull Request: https://github.com/NetBSD/pkgsrc/pull/65