search

NetCal / DNC

The NetworkCalculus.org Deterministic Network Calculator
http://dnc.networkcalculus.org
GNU Lesser General Public License v2.1
25 stars 23 forks source link

Fixing issue #80: Overriding hashCode and equals. #82

Closed davidalain closed 5 years ago

davidalain commented 5 years ago

(Link: Issue #80)

davidalain commented 5 years ago

Could you please use the same formatter as we use? Would not highlight the whole file as changed. Even just setting automatic formatter for changed code would help.

@matyesz Sorry for that, I'm looking for how to fix it. May I do a new pull request?

NetCal commented 5 years ago

Could you please use the same formatter as we use? Would not highlight the whole file as changed. Even just setting automatic formatter for changed code would help.

@matyesz Sorry for that, I'm looking for how to fix it. May I do a new pull request?

I don't think this is necessary. Changing the files in your branch for this PR should work, too.

And looking at your branch, I realize that you are working on v2.5, requesting a merge into v2.5. Could you please prepare your changes to be included into the master branch? Master has the current v2.6 code base. The numbered branches are only storing old (and obsolete) versions of the DNC for easy access to those used in paper evaluations.

davidalain commented 5 years ago

Could you please use the same formatter as we use? Would not highlight the whole file as changed. Even just setting automatic formatter for changed code would help.

@matyesz Sorry for that, I'm looking for how to fix it. May I do a new pull request?

I don't think this is necessary. Changing the files in your branch for this PR should work, too.

And looking at your branch, I realize that you are working on v2.5, requesting a merge into v2.5. Could you please prepare your changes to be included into the master branch? Master has the current v2.6 code base. The numbered branches are only storing old (and obsolete) versions of the DNC for easy access to those used in paper evaluations.

Done in #84

sbondorf commented 5 years ago

Could you please use the same formatter as we use?

Given that this goes into the v2.5 branch as a "best effort backport", I am fine with merging anyways. PR #84 getting these changes into master does not have the formatting/indentation problem.