NetComposer / nklib

NetComposer common library functions
Apache License 2.0
11 stars 38 forks source link

JSON library #13

Closed silviucpp closed 5 years ago

silviucpp commented 5 years ago

I see for json right now you are using 2 libraries and basically in the encoding/decoding process you are checking which one is available.

I think best JSON lib for erlang at this point is https://github.com/sile/jsone . And I will recommend using only one library and remove that checks that adds additional overhead.

silviucpp commented 5 years ago

BTW if you are interested I can submit a pull request

kalta commented 5 years ago

Thank you, I switched jsx for jsone.

However I kept the jiffy check. We do a lot of heavy JSON processing and jiffy is still faster and battle tested (for us). We don't know yet how jsone would perform yet.

The only check is erlang:function_exported/2 and that should be very fast.