NetComposer / nklib

NetComposer common library functions
Apache License 2.0
11 stars 35 forks source link

Fix nklib_util:strip and EDoc in Makefile #5

Closed jbgledy closed 8 years ago

kalta commented 8 years ago

Hi, thank you.

Ok to the EDoc fix, but please put it alone in a specific pull request. As far as I know GitHub does not allow to accept "partial" pull requests.

In relation with the strip request: The strip/1 function is in fact designed to remove only heading whitespace, not trailing. It is used heavily in parser functions that go only ahead processing, and only need to remove current whitespace. You are however right in that the heading of the function says that it removes trailing space, while it is quite the opposite! You can't change the behavior of strip/1, many other functions depend on it. If you need a function to remove heading and trailing whitespace, you should create a new, different function.