NetCordDev / NetCord

The modern and fully customizable C# Discord library.
https://netcord.dev
MIT License
65 stars 10 forks source link

Update build to include PR's in workflows #33

Closed csmir closed 2 months ago

csmir commented 2 months ago

Testing if this runs build

KubaZ2 commented 2 months ago

It's not the best idea I think, because on pull request only activates when the pull request is created, it won't trigger for additional pushes to the source branch.

csmir commented 2 months ago

It is not a bad idea I think, it will rerun the build process every time a new push is made to the pull request. It can even be installed that the PR must succeed build before being able to be merged.

KubaZ2 commented 2 months ago

It is not a bad idea I think, it will rerun the build process every time a new push is made to the pull request. It can even be installed that the PR must succeed build before being able to be merged.

You are right, sorry, what do you think about adding types: [opened, synchronize]? That's what is used in https://github.com/NetCordDev/NetCord/blob/alpha/.github/workflows/documentation-preview.yml#L5

csmir commented 2 months ago

You are right, sorry, what do you think about adding types: [opened, synchronize]? That's what is used in https://github.com/NetCordDev/NetCord/blob/alpha/.github/workflows/documentation-preview.yml#L5

The only thing you lose out on in this circumstance is when the PR is reopened. All further logic remains the same. I honestly do not think it is necessary

KubaZ2 commented 2 months ago

Not really, there are many activity types:

Also I think running on reopened is not needed

csmir commented 2 months ago

My bad, I read this: image and thought that was all it was

KubaZ2 commented 2 months ago

Well, you are right then, we would only lose reopened there, though I still think reopened is not needed

KubaZ2 commented 2 months ago

Thanks!