search

NetCordDev / NetCord

The modern and fully customizable C# Discord library.
https://netcord.dev
MIT License
65 stars 10 forks source link

Added XML documentation for Embed.cs, first of many #9

Closed Red-K0 closed 9 months ago

Red-K0 commented 9 months ago

Could you please add a new line above each XML documentation?

Done and done

Red-K0 commented 9 months ago

Updated a fair amount of the documentation to account for review comments.

Red-K0 commented 9 months ago

Modified mentions of URLs to strings containing URLs, and matched review comments

KubaZ2 commented 9 months ago

This isn't what I meant. I meant that the type of something that is documented as an URL should be a string. The doc should be for example A thumbnail containing an URL that represents the image or something similar I think

Red-K0 commented 9 months ago

A thumbnail containing a URL? Not quite following what you mean

KubaZ2 commented 9 months ago

Yeah, EmbedThumbnail contains a property named Url alongside with other properties. I don't think calling the whole thing an URL is good because it only contains the URL

Red-K0 commented 9 months ago

Should be fixed now

KubaZ2 commented 9 months ago

Looks good to me now, thank you