search

NetDevelopersPoland / NetDevPLWebsite

MIT License
22 stars 24 forks source link

Fix new year ArgumentOutOfRangeException in facebook's posts #65

Closed rwojcik closed 7 years ago

rwojcik commented 7 years ago

Since there are no posts yet for facebook in this year (http://netdevelopers.pl/facebook/top-current-year) server currently throws an exception System.ArgumentOutOfRangeException in HLListPage.cs:25. I've decided not to use this class (sorry @pawelklimczyk :D), change this to List<> and prompt user that there are no posts found.

pawlos commented 7 years ago

@rwojcik it looks like it doesn't build. Check the AppVeyor logs

pawelklimczyk commented 7 years ago

I will fix that in HandyLib. HLListPage was introduced because it has build-in pagination mechanism... I will fix that tomorrow...

rwojcik commented 7 years ago

Well, if it's going to be fixed in HLListPage then there is no point in keeping this PR

pawelklimczyk commented 7 years ago

Part of it was fixed in HLListPage whole fix is here: https://github.com/NetDevelopersPoland/NetDevPLWebsite/commit/97508f3dc006d1a61b94d248ec21a5ee1931972a