NetDocuments-Archive / ad-join-cookbook

Chef cookbook to join windows computer to AD
Apache License 2.0
14 stars 12 forks source link

NoMethodError: undefined method `domain_password' for Chef::Resource::Execute #39

Open sredne opened 5 years ago

sredne commented 5 years ago

It looks like there might new_resource missing on line 34 of the ubuntu 16.04 resource.

PS S:\sourcecode\linux> kitchen converge post-provisioning -----> Starting Kitchen (v1.23.2) -----> Converging ... Preparing files for transfer Preparing dna.json Resolving cookbook dependencies with Berkshelf 7.0.6... Removing non-cookbook files before transfer Preparing validation.pem Preparing client.rb -----> Chef Omnibus installation detected (install only if missing) Transferring files to Starting Chef Client, version 14.4.56 resolving cookbooks for run list: ["linux::join_domain"] Synchronizing Cookbooks:

spuder commented 5 years ago

Correct, line 35 and line 57 should both be changed from

    environment 'DOMAIN_PASS' => domain_password

to

environment 'DOMAIN_PASS' => new_resource.domain_password

I'll push change shortly. @aredeex or @jordangillespie will need to publish the change to the super market

sredne commented 5 years ago

Hey @spuder ,

Do we have an ETA on when this will be published to the supermarket? I'd like to use it using the supermarket without having to pull from source.

spuder commented 5 years ago

@aredeex I've pushed 5.1.2 to the supermarket

knife cookbook site share "ad-join" "Operating Systems & Virtualization" -z --dry-run