search

NetDocuments-Archive / rd-winrm-plugin

Allows rundeck to execute commands with powershell
Apache License 2.0
31 stars 19 forks source link

Request : update winrm and winrm-fs #43

Closed FireHelmet closed 6 years ago

FireHelmet commented 7 years ago

Hello,

Could you update your plugin to use the last updates of winrm and winrm-fs ?

Winrm : 2.2.1 Winrm-fs : 1.0.1

Thank to you for your great plugin.

FireHelmet commented 7 years ago

Hello,

Some news about that ?

:)

spuder commented 7 years ago

We aren't actively using the plugin at the moment, so we don't have a way to test this. Pull requests welcome.

FireHelmet commented 7 years ago

Hello spuder,

Thank for your answer. I'm using this fork https://github.com/stoned/rd-winrm-plugin/tree/gem-winrm-2 of your project from 1 month without problem in production. Maybe you can merge your code :) and this topic will be solved.

Thanks !

vvchik commented 7 years ago

I've reviewed your code, quickly. On the first impression, it looks good. Please create PR. :)

FireHelmet commented 7 years ago

It's not my code, it's from Stoned (user). I'm not a power user of Github, but I think my PR it's well done: https://github.com/NetDocuments/rd-winrm-plugin/pull/45

Thanks !

vvchik commented 7 years ago

Oh, It is my mistake I didn't realize that code from another user. I not so powerful in licensing, but I think we need to have @stoned approval, before merging it.

stoned commented 7 years ago

Hi, There is no problem on my side. You could proceed with the PR. Thank you for your time !

FireHelmet commented 7 years ago

@stoned Thank to you.

FireHelmet commented 7 years ago

@vvchik ,

Could you merge the PR ?

Thanks

DerfOh commented 7 years ago

@vvchik ping! I would like to see this merged too. Thanks for all your hard work @stoned and everyone else :smiley:

spuder commented 7 years ago

Before that can be merged, the version number needs to be fixed. 1.6.0.1 isn't the right version number, it needs to be 1.7.0

FireHelmet commented 7 years ago

@stoned Could you update the version like asked by @spuder ?

Thank you for your work !

UnicodeTreason commented 6 years ago

This has been resolved by https://github.com/NetDocuments/rd-winrm-plugin/pull/50 and https://github.com/NetDocuments/rd-winrm-plugin/pull/49 so can be closed.