search

NetDocuments-Archive / rd-winrm-plugin

Allows rundeck to execute commands with powershell
Apache License 2.0
31 stars 19 forks source link

Updated gems, Added No SSL, Add Error handling #49

Closed UnicodeTreason closed 6 years ago

UnicodeTreason commented 6 years ago

Hi guys,

I pulled in the changes Stoned and Rodolfo made in my personal branch, then built on top of those some improvements I've been wanting around the error handling.

You'll now only get the full Ruby stack trace if the job is ran in DEBUG mode. Otherwise you'll get a simple message in NORMAL mode, this makes the plugin much friendlier for non dev's reading the job outputs and for parsing in other systems.

Any other requests/recommendations? I'm using this updated code on both my Test and Production systems at the moment with no issue.

UnicodeTreason commented 6 years ago

I removed the attempted quote problem fix from lines 32 to 38 as I found it made no difference in my testing.

Rundeck have documented the problem and solution in their documentation so I feel that is adequate until they fix the bug internally: http://rundeck.org/docs/manual/jobs.html#quoting-arguments-to-steps

Happy for other POV's/input on this choice.

spuder commented 6 years ago

This looks like a pretty big change. Should this be 1.7.0 and not 1.6.2 ?

UnicodeTreason commented 6 years ago

Yes it should be, seems I missed the CHANGELOG. Any other changes required? Would you like me to update to releases with v1.7.0? I already have the .zip ready

spuder commented 6 years ago

Does this work? We aren't actively using rundeck at the moment so we can't test this. If you are confident, I'll accept this.

UnicodeTreason commented 6 years ago

It does, I'm currently running it in Production against ~9000 servers.

ltamaster commented 6 years ago

Hi guys,

I tested this and it worked OK.

Luis