NetFPGA / NetFPGA-PLUS

46 stars 22 forks source link

Why is tready signal from output_queues.v is set to always 1? #4

Open Horacehxw opened 2 years ago

Horacehxw commented 2 years ago

hw\lib\std\output_queues_v1_0_0\hdl\output_queues.v, line 411.

The tready signal is set to always 1, is there any reason not to set it according to fifo status?

If I want the tready signal to be 0 when the fifo is full like the following snippet, will the logic be valid?

assign s_axis_tready = ~|((nearly_full | metadata_nearly_full) & oq);

aomtoku commented 1 year ago

Hi @Horacehxw , I am really sorry for my late response.

Our architecture takes basic network datapath - aggregating all of interfaces to single datapath, and disaggregating packets to ports. When one of ports is congested then, all traffic has to be stopped here if the logic is valid. So, currently, output queue module always accept packet from the behind module (output port look module). And, If output queue module cannot handle the packet, the packet will go to the DROP state to be discarded, so I think this logic should work for switch and router cases. If you find any corner cases, please let me know.