Respect PRIVACYIDEA_CONFIGFILE environment variable

NetKnights-GmbH / privacyidea-appliance

two-factor authentication system. This is a setup tool for easy system setup.

GNU Affero General Public License v3.0

4 stars 4 forks source link

Respect PRIVACYIDEA_CONFIGFILE environment variable #69

Open plettich opened 5 years ago

plettich commented 5 years ago

Currently, the pi-appliance tool uses a privacyIDEA config file different from /etc/privacyidea/pi.cfg if it is passed with parameter -f.

fredreichbier commented 5 years ago

Ouh, good point, the handling of config files is a bit problematic at the moment.

I think our "privacyIDEA admins" configuration menu respects PRIVACYIDEA_CONFIGFILE, but does not respect -f.

Our "privacyIDEA loglevels" configuration menu respects -f, but not PRIVACYIDEA_CONFIGFILE.

And whenever we call pi-manage in a subprocess, we respect neither -f nor PRIVACYIDEA_CONFIGFILE :-)

cornelinux commented 4 years ago

Hontestly: I would remove the -f option. This was from a time, when the idea was to keep the pi-appliance flexible. But honestly, it is used in a very specific environment where we always know that the config file will be at /etc/privacyidea/pi.cfg. So I simply would remove this option.