search

NetKnights-GmbH / ubuntu

Ubuntu build environment for privacyIDEA
3 stars 4 forks source link

radius: dictionary for privacyIDEA-Serial is missing #29

Open cornelinux opened 4 years ago

cornelinux commented 4 years ago

The package privacyidea-radius is missing the file dictionary.netknights, that specifies the RADIUS attribute privacyIDEA-Serial.

# -*- text -*-
#
#   privacyIDEA dictionary
#

VENDOR      NetKnights          44929

#  Backwards compatibility.
BEGIN-VENDOR    NetKnights

ATTRIBUTE   privacyIDEA-Serial                  1   string

END-VENDOR  NetKnights
cornelinux commented 4 years ago

We could add this file to /usr/share/freeradius/dictionary.netknights. In this case it would be available but not active, yet. The admin could then include it either systremwide in /usr/share/freeradius/dictionary or in the local /etc/freeradius/3.0/dictionary.

As another option we could immediately modify the local dictionary file /etc/freeradius/3.0/dictionary, which does not sound that elegant.

As most installations probably will not use the privacyIDEA-Serial I think simply shiipping the file would be enough. Also, the attribute is not used in rlm_perl.ini anymore per default, so not activating the dectionary would totally fine, since no error is contained in the log file.

superit20 commented 3 years ago

Maybe default /etc/privacyidea/rlm_perl.ini should contain [Mapping] serial = privacyIDEA-Serial after provacyIDEA installation? That will be a straightforward soultion.

cornelinux commented 3 years ago

@superit20 This entry is already contained. But the problem is, that privacyIDEA-Serial is not defined as a RADIUS Attribute!